Something Vite does, which is kinda cool, is gives you a control of how big an image is before it is rendered via a data URL vs referenced as an HTTP URL.

Imported or referenced assets that are smaller than this threshold will be inlined as base64 URLs to avoid extra http requests. Set to 0 to disable inlining altogether.

Source

I wonder if there is something interesting we can do here, in tandem with a public disk, where generated images of smaller sizes are rendered as a data url and others are stored on a public disk and rendered as a http url, all handled seamlessly.

Note that I haven't deep dived the image feature, so I don't know the internals or how things work under the hood to know if this totally makes sense as a suggestion.

Note that attribute values aren't escaped in there, which means in the case of your example $image->toHtml(['alt' => 'My avatar']), if the user provides the value for alt, then it opens up an easy XSS vector. This is something Laravel prevents with attributes on Blade components by default. Plus, Htmlable allows it to be used as {{ $image }} - which makes it feel safer, even though it's not.

For example:

// $user->display_name => "><script>alert(document.cookie)</script>

$image->toHtml(['alt' => $user->display_name]);

Outputs:

<img src="data:image/png;base64,…" width="100" height="100" alt=""><script>alert(document.cookie)</script>">

At a minimum, wrapping the values in e() should lock it down:

->map(fn ($value, $key) => sprintf('%s="%s"', e($key), e($value)))

But I would suggest looking into how Blade components handle attributes in Illuminate\View\ComponentAttributeBag to handle more than just string attributes.

I think a component would be more appropriate to solve this problem.

@browner12 I thought about that, too, but Laravel doesn't ship its own components, does it?

Something Vite does, which is kinda cool, is gives you a control of how big an image is before it is rendered via a data URL vs referenced as an HTTP URL.

Imported or referenced assets that are smaller than this threshold will be inlined as base64 URLs to avoid extra http requests. Set to 0 to disable inlining altogether.
Source

I wonder if there is something interesting we can do here, in tandem with a public disk, where generated images of smaller sizes are rendered as a data url and others are stored on a public disk and rendered as a http url, all handled seamlessly.

Note that I haven't deep dived the image feature, so I don't know the internals or how things work under the hood to know if this totally makes sense as a suggestion.

@timacdonald Great idea, I thought about this as well, however,

• this would require a new config value and I intentionally left the scope small (arguably, additional attributes already have their complexity ^^)
• it could be confusing if "Turn into an HTML tag" interacts with the file system

AFAIK it doesn't currently, although I think there are some situations it should. Basically anytime we're using a method like this to spit out HTML, a component is IMO better suited to solve the problem. For example, I PR'ed a Pagination component many months ago that got rejected. So rather than

{!! $users->links() !!}

it would be something like

<x-laravel.pagination
    :models="$users"
    :perpage="5"
    :showPages="true"
></x-laravel.pagination>

I've been tempted to try this again lately, but Taylor obviously was uninterested before.

If that's still the case, my opinion would be this belongs as a userland solution.

this would require a new config value and I intentionally left the scope small (arguably, additional attributes already have their complexity ^^)

Other things, I thought about but considered out of scope for now:

• outputting a <figure> with a <figcaption>
• outputting a <picture> (this would be interesting when we could create multiple versions of an image simultaneously)
• Having the additional attributes as part of the classes metadata as class properties
• Using file metadata for alt (e.g. COMMENT or COMPUTED.UserComment)

AFAIK it doesn't currently, although I think there are some situations it should. Basically anytime we're using a method like this to spit out HTML, a component is IMO better suited to solve the problem. For example, I PR'ed a Pagination component many months ago that got rejected. So rather than

{!! $users->links() !!}

it would be something like

<x-laravel.pagination
    :models="$users"
    :perpage="5"
    :showPages="true"
></x-laravel.pagination>

I've been tempted to try this again lately, but Taylor obviously was uninterested before.

@browner12 Yeah, a penny for this man's thoughts … ^^

I mean, same with official enums, value objects, etc.

Maybe, we first need an official laravel/components for this 😂

Note that attribute values aren't escaped in there, which means in the case of your example $image->toHtml(['alt' => 'My avatar']), if the user provides the value for alt, then it opens up an easy XSS vector. This is something Laravel prevents with attributes on Blade components by default.

At a minimum, wrapping the values in e() should lock it down

@valorin Good catch! I went with the e() solution 👍🏻

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!